Add max value for balance calculation #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
| @@ -50,6 +50,7 @@ export const hruRules = _applyRules([ | |||
| export const balanceRules = _applyRules([ | |||
| isNumeric("Balance must be a valid number."), | |||
| min("Minimum allowed balance is 0.", 0), | |||
| max("Maximum allowed balance is 1000000000000000 TFT.", 10 ** 15), | |||
There was a problem hiding this comment.
can we make it "Maximum allowed balance is 10e15" ? It is difficult keeping track of all the zeros
| @@ -50,6 +50,7 @@ export const hruRules = _applyRules([ | |||
| export const balanceRules = _applyRules([ | |||
| isNumeric("Balance must be a valid number."), | |||
| min("Minimum allowed balance is 0.", 0), | |||
| max("Maximum allowed balance is 10e15 TFT.", 10 ** 15), | |||
There was a problem hiding this comment.
my bad should be 1e15, not 10e15.
amiraabouhadid
approved these changes
Oct 23, 2024
0oM4R
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add max value for balance calculation to be
1000000000000000.Changes
Related Issues
Tested Scenarios
Try to add more than
1000000000000000in balance input.Checklist